Stable/0.8.x #24
Open
Stable/0.8.x #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce images, and catch that in InageNode.render so that we're not masking unrelated IOErrors elsewhere in the get_rendition process
… exactly 2 arguments (1 given)' error for RoutablePage previews
…t kills the background colour
…ake the fix into a shared _to_rgb helper method
… don't look horrible
Fixes #837 When copying a page, all of its revisions are also copied. The revisions are JSON encoded and include ID fields which point back to the original page object. These IDs weren't being updated when the revision was copied to a new page causing the editor to break when that new page is edited.
This serves two purposes: * It makes sure update_attrs gets applied to the latest revision so the changes are reflected in the editor * It bumps the last_revision_created_at value so the new page gets ordered as if it was just created
This is used for setting the owner of the new pages and the user for the new revision that gets created Conflicts: wagtail/wagtailadmin/views/pages.py
Conflicts: wagtail/wagtailforms/tests.py
Conflicts: wagtail/wagtailforms/models.py
Less complicated and a bit more isolated now Conflicts: wagtail/wagtailembeds/tests.py
Conflicts: wagtail/wagtailembeds/tests.py
Conflicts: wagtail/wagtailembeds/tests.py
Conflicts: wagtail/wagtailembeds/tests.py
Conflicts: wagtail/wagtailembeds/embeds.py
Conflicts: wagtail/wagtailcore/tests/test_page_model.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Wagtail! 🎉
Before submitting, please review the contributor guidelines https://docs.wagtail.io/en/latest/contributing/index.html and check the following:
make lintfrom the Wagtail root)