Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Work-in-Progress] New UI #452

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

Deep-Chill
Copy link
Contributor

@Deep-Chill Deep-Chill commented Mar 19, 2024

This is a WIP implementation of the UI changes.
'new_assess' is a test directory, it'll replace the code in app/assess and app/scorecard in the final version.

new_assess/scorecard/index.html is the current working file.

Currently working on:

  • Move all the current changes to the original views/templates
  • Recheck Vue and View to ensure compatbility
    • Vue
      • Issue with url/itemlistmixin, maybe the best solution would be to use the existing campaign-questions-list and scorecard components.
      • View is clashing with prefix and itemlistmixin
  • Fix chart
    • Missing the first item in the scorecard
  • Fix scorecard showing before assessment on page load
    • Scorecard should calculate on a new assessment when we switch to the assess mode. It should instantly calculate based on toggle.
  • Change prefix upon toggling view to empty string
  • Improved logic for switching between the assess and the scorecard in the template
  • remove the checkmarks
  • practiceslistmixin is creating the chart and calling all the other methods before they’re necessary
  • Preload scorecard
  • Set sidebar buttons to open the tile
  • Use implemented divs instead of tables
  • Fix bug: Users can still change answers after an assessment is frozen because it creates a new sample. Need to investigate why this is happening.

This is a WIP implementation of the UI changes.
'new_assess' is a test directory, it'll replace the code in app/assess and app/scorecard in the final version.

new_assess/scorecard/index.html is the current working file.

Currently working on:
- [ ]  Move all the current changes to the original views/templates
- [ ]  Recheck Vue and View to ensure compatbility
    - [ ]  Vue
      - [ ]  Issue with url/itemlistmixin, maybe the best solution would be to use the existing campaign-questions-list and scorecard components.
    - [ ]  View is clashing with prefix and itemlistmixin
- [ ]  Fix chart
    - [ ]  Missing the first item in the scorecard
- [ ]  Fix scorecard showing before assessment on page load
    - [ ]  Scorecard should calculate on a new assessment when we switch to the assess mode. It should instantly calculate based on toggle.
- [ ]  Change prefix upon toggling view to empty string
- [ ]  Improved logic for switching between the assess and the scorecard in the template
- [ ]  remove the checkmarks
- [ ]  practiceslistmixin is creating the chart and calling all the other methods before they’re necessary
- [ ]  Preload scorecard
- [x]  Set sidebar buttons to open the tile
- [ ]  Use implemented divs instead of tables
- Instead of creating a new component that merges everything in the campaign-questions-list and scorecard components, this code is using the existing components with slight modifications and using keep-alive to keep both of them alive.
- A new smaller component (currently) named `new-assess` is used to keep track of the sidebar.
- The main html file is
`new_assess/scorecard/index.html` and the view is in `views/new_assess.py`

Currently working on:
- Investigating why a new sample is created whenever an assessment gets frozen.
- Adding Share assessment button
- Replacing tables with divs.

Need clarifications on:
- the exact behavior once a sample gets frozen and where the user should be redirected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant