Fix void[] initializer and test for it

variable was never inserted, so test didn't fail because there was no check that all variables have been covered.
dlang-community · Aug 31, 2021 · a29d40a · a29d40a
1 parent 36563f7
commit a29d40a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/src/dsymbol/conversion/first.d b/src/dsymbol/conversion/first.d
@@ -1485,14 +1485,11 @@ class InitializerVisitor : ASTVisitor
 	{
 		// If the array has any elements, assume all elements have the
 		// same type as the first element.
-		if (ai.arrayMemberInitializations)
-		{
-			if (ai.arrayMemberInitializations.length)
-				ai.arrayMemberInitializations[0].accept(this);
-			else
-				lookup.breadcrumbs.insert(VOID_SYMBOL_NAME);
+		if (ai.arrayMemberInitializations.length)
+			ai.arrayMemberInitializations[0].accept(this);
+		else
+			lookup.breadcrumbs.insert(VOID_SYMBOL_NAME);
 
-		}
 		lookup.breadcrumbs.insert(ARRAY_LITERAL_SYMBOL_NAME);
 	}
 

diff --git a/src/dsymbol/tests.d b/src/dsymbol/tests.d
@@ -54,6 +54,7 @@ void expectSymbolsAndTypes(const string source, const string[][] results,
 			i++;
 		}
 	}
+	enforce!AssertError(i == results.length, "too many expected results, %s is left".format(results[i .. $]), file, line);
 }
 
 @system unittest
-Original file line number
+Diff line change
@@ Expand Up @@
     			i++;
     		}
     	}
+    	enforce!AssertError(i == results.length, "too many expected results, %s is left".format(results[i .. $]), file, line);
     }
     @system unittest
@@ Expand Down @@