PackageManager: Support directly loading a sub-package via path-based getOrLoadPackage()
#2977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ PR OK, no changes in deprecations or warnings Total deprecations: 0 Total warnings: 0 Build statistics: statistics (-before, +after)
-executable size=5105200 bin/dub
+executable size=5109296 bin/dub
rough build time=60sFull build output |
kinke
commented
Nov 5, 2024
| @@ -271,7 +271,8 @@ class PackageManager { | |||
| foreach (ovr; repo.overrides) | |||
| if (ovr.package_ == name.toString() && ovr.source.matches(ver)) { | |||
There was a problem hiding this comment.
I guess the overrides should only apply to base packages as a whole, not on a sub-package basis. I.e., ovr.package_ == name.main.toString().
kinke
commented
Nov 5, 2024
kinke
force-pushed
the
path_based_subpackages
branch
2 times, most recently
from
c6c8a6b to
8aec744
Compare
kinke
commented
Nov 6, 2024
| mode = Whether to issue errors, warning, or ignore unknown keys in dub.json | ||
|
|
||
| Returns: The packages loaded from the given path | ||
| Throws: Throws an exception if no package can be loaded | ||
| */ | ||
| Package getOrLoadPackage(NativePath path, NativePath recipe_path = NativePath.init, | ||
| bool allow_sub_packages = false, StrictMode mode = StrictMode.Ignore) | ||
| PackageName name = PackageName.init, StrictMode mode = StrictMode.Ignore) |
There was a problem hiding this comment.
The breaking API change is in a separate 2nd commit, in case we cannot/don't want to break it.
Geod24
approved these changes
May 14, 2025
|
LGTM. Feel free to rebase + merge. I've been wanting to have a much more in-depth change to the PackageManager since forever (storing packages hierarchically in memory) but never finished it. I think that's a pretty good improvement, sorry for forgetting to review it for so long. |
… getOrLoadPackage() To avoid a costly full packages scan to resolve the sub-package later.
kinke
force-pushed
the
path_based_subpackages
branch
from
2cc1e07 to
07a6a5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid a costly full packages scan to resolve the sub-package later.