Skip to content

Eliminate redundant allocation in to!string for types with toString #10664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Eliminate redundant allocation in to!string for types with toString #10664

Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
7d8615f
Fix Bugzilla Issue 24739 - to!string creates unnecessary allocation f…
deveshidwivedi Mar 8, 2025
f39264c
add comment on to!string not optimizing for classes
deveshidwivedi Mar 11, 2025
4327773
remove class limitation
deveshidwivedi Mar 11, 2025
e308db6
use assert in unittest
deveshidwivedi Mar 12, 2025
4f98842
address incorrect char[] conversion
deveshidwivedi Mar 13, 2025
4a9b434
address remaining conditions
deveshidwivedi Mar 14, 2025
6381b03
remove trailing whitespace
deveshidwivedi Mar 14, 2025
02c72f2
fix failing test
deveshidwivedi Mar 14, 2025
7bd66a2
add condition to catch remaining return types
deveshidwivedi Mar 18, 2025
9ac7202
Align toString usage with formatValueImpl
deveshidwivedi Mar 20, 2025
d053720
fix failing test
deveshidwivedi Mar 20, 2025
ed2827a
add suggested change
deveshidwivedi Mar 22, 2025
c857921
add suggested change
deveshidwivedi Mar 22, 2025
bd18c8c
Add missing closing parenthesis
pbackus Mar 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion std/conv.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1013,7 +1013,13 @@ if (!(is(S : T) &&
!isEnumStrToStr!(S, T) && !isNullToStr!(S, T)) &&
!isInfinite!S && isExactSomeString!T)
{
static if (isExactSomeString!S && value[0].sizeof == ElementEncodingType!T.sizeof)
static if (is(S == struct) &&
is(typeof(value.toString()) Ret : T) &&
isSomeString!Ret)
{
return value.toString();
}
else static if (isExactSomeString!S && value[0].sizeof == ElementEncodingType!T.sizeof)
{
// string-to-string with incompatible qualifier conversion
static if (is(ElementEncodingType!T == immutable))
Expand Down Expand Up @@ -1121,6 +1127,18 @@ if (!(is(S : T) &&
return toStr!T(value);
}
}
// https://issues.dlang.org/show_bug.cgi?id=24739
@system unittest
{
import std.conv : to;

struct S
{
string toString() { return "S"; }
}

assert(S.init.toString().ptr == S.init.to!string.ptr);
}

// https://issues.dlang.org/show_bug.cgi?id=14042
@system unittest
Expand Down
Loading