Skip to content

Fix dlang#10798 — Reimplement FFT solver to support @nogc nothrow pure @safe #10799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 32 commits into
base: master
Choose a base branch
from

Conversation

Ogi-kun
Copy link
Contributor

@Ogi-kun Ogi-kun commented Jun 7, 2025

  • FFT solver is reimplemented as a struct called FFT. It either allocates a buffer for a lookup table using malloc, or uses a preallocated buffer. In the former case, the buffer is freed upon destruction. FFT is non-copyable.
  • Fft class now is just a wrapper around FFT.
  • Convenience functions use FFT instead of Fft. In effect, fft(R, Ret) and inverseFft(R, Ret) can be used in @nogc, nothrow, pure and @safe code.

Though the optimization of the algorithm itself was not the goal of this change, the new version performs slightly better on the larger FFT sizes. Using LDC2 with -O -release flags, on size=64 FFT.compute works about as fast as the old Fft.fft, and on size=32768 it works 6-7 % faster. DMD shows similar results.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @Ogi-kun! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#10799"

@Ogi-kun Ogi-kun changed the title Fix dlang#10796 - FFT doesn’t work with user-defined complex types Fix dlang#10798 — make FFT fully compatible with @nogc Jun 7, 2025
@Ogi-kun Ogi-kun changed the title Fix dlang#10798 — make FFT fully compatible with @nogc Fix dlang#10798 — Reimplement FFT solver to support @nogc nothrow pure @safe Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants