-
-
Notifications
You must be signed in to change notification settings - Fork 748
Move std.experimental.all to std #6889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + phobos#6889" |
|
Huh? |
ghost
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, let's get the merge
PetarKirov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this, I'm strongly in favor!
It needs a little bit of work on the ddoc side, but I think this can only be done in the dlang/dlang.org repo after this PR is merged. (E.g. we need to link the std/package.d docs from more places.)
|
Hey @wilzbach, you up for finishing this PR? |
|
@andralex do we have a go or no go from your side? |
andralex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of changes requested. Let's do this, thanks for the work.
d3b64a2 to
1e7be28
Compare
|
OK. I went through the comments and also added a proper deprecation message for std.experimental.all. -> this should be good to go now (: |
|
Automerge added. |
|
Force merging as Walter's recent -dip1000 push broke CircleCi. |
std.experimental.allhas been added more than a year ago (see #5916).When we added it, we agreed to use
experimentalfirst to see whether there are any flaws with such a convenience package.As none of these have been discovered and on the contrary more work has been started (and merged in some cases) which makes the compiler (or at least Phobos) compile faster.
Also, as the D community started to like this package, I think this was successful experiment and we should stabilize it.
BTW any interested reader can find a lot of examples of
std.experimental.allin action in D forums posts.A short excerpt:
...
Also, once this is stabilized, I can finally enable it by default for
run.dlang.io.