fix: Move lower-cased names to a separate map to fix overlapping cases #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabe565
force-pushed
the
split-lower-value-map
branch
from
b25a89e to
71aa571
Compare
gabe565
changed the title
gabe565
force-pushed
the
split-lower-value-map
branch
from
71aa571 to
5a3855d
Compare
gabe565
changed the title
gabe565
force-pushed
the
split-lower-value-map
branch
from
5a3855d to
34ad3cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of my two solutions to fix #40.
Split
_typeNameToValueMapinto_typeNameToValueMapand_typeLowerNameToValueMap._typeNameToValueMapis checked first with a fallback to the lower-cased map. This lets the current case-insensitivity behavior stay the same, while also choosing the correct value if there are overlaps.Unfortunately, the golden files will all need to be updated if we go this route. Is there are way to re-generate them?(Used the golden test to regenerate).Fixes #40