Skip to content

Strict in_array check as per WP coding standards and use WordPress checked #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tangrufus wants to merge 2 commits into from
Closed

Strict in_array check as per WP coding standards and use WordPress checked #17

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9817267
Strict in_array check as per WP coding standards
tangrufus Sep 8, 2017
5137dd9
Use WordPress checked
tangrufus Sep 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 1 addition & 19 deletions admin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ function DRA_display_route_checkboxes() {

foreach ( $all_routes as $route ) {
$is_route_namespace = in_array( ltrim( $route, "/" ), $all_namespaces );
$checkedProp = DRA_get_route_checked_prop( $route, $whitelisted_routes );
$checkedProp = checked( in_array( esc_html( $route ), $whitelisted_routes, true ), true, false );

if ( $is_route_namespace || "/" == $route ) {
$current_namespace = $route;
Expand All @@ -77,21 +77,3 @@ function DRA_display_route_checkboxes() {
}
echo "</ul>";
}


/**
* During comparison, encode the route being requested in the same fashion that it's stored in the database option
* Encoding during save happens in Disable_REST_API::maybe_process_settings_form()
*
* @param $route
* @param $whitelisted_routes
*
* @return string
*/
function DRA_get_route_checked_prop( $route, $whitelisted_routes ) {
if ( in_array( esc_html( $route ), $whitelisted_routes ) ) {
return "checked='checked'";
}

return "";
}