Removes unnecessary dependecy and updates package for Python 3.x#9
Open
shackra wants to merge 5 commits intodmclain:masterfrom
Open
Removes unnecessary dependecy and updates package for Python 3.x#9shackra wants to merge 5 commits intodmclain:masterfrom
shackra wants to merge 5 commits intodmclain:masterfrom
Conversation
The code worked only for Python 2.7 and Heroku by default will deploy Python apps with Python 3.6.x
The former is the correct class to use as class decorator - Pylons/pyramid@c9888fc - https://twistedmatrix.com/trac/ticket/8438
iabdulazeem
approved these changes
Jul 3, 2020
iabdulazeem
left a comment
There was a problem hiding this comment.
Thanks for removing distribute package, It's causing error in deployment. Please merge it ASAP.
|
Is this branch merged into main ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this should resolve #8