Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Prevent throw on empty source record #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kauz56
Copy link

@kauz56 kauz56 commented Aug 20, 2024

@dmitryd Had a case where translation would get stuck on some records with the following message:

Uncaught TYPO3 Exception: Dmitryd\DdDeepl\Service\DeeplTranslationService::translateRecord(): Argument #2 ($record) must be of type array, null given, called in .../vendor/dmitryd/dd-deepl/Classes/Hook/DataHandlerTranslationHook.php on line 86

Didn't have time to investigate this further, but this seemed to resolve the issue without causing any noticable problem with the translated records. This was a "standard" site using an unmodified dd_deepl v12.7.0. Languages were en -> es. A glossary was used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant