[R] Deprecation warning for non-function objective as argument #11204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #9810
ref #9734 (comment)
Previously, functions
xgb.trainandxgb.cvwere accepting parameters as either function arguments or as entries underparams, but now they have been changed to only acceptparams.One problematic case here is
objective, since it is accepted as a function argument when it is a function, in line with the python package.The warning-on-deprecation mechanism thus doesn't cover the case of built-in objectives being passed as parameters. This PR should fix it, and hopefully help to ease migration and avoid failures in reverse dependencies.