[R] Switch to xgb.train inside xgboost() when passing DMatrix and no "y"
#11232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Given this was a common error in reverse dependency checks, it seems prudent to catch that and at least give some advice to ease the changeover for users and developers. (I cannot comment on the specific fallback code.) I'd also recommend making the (temporary) "xgboost.strict_mode" mechanism settable via an environment variable, so developers can enable it easily to test their packages, including when running R CMD check. |
This was referenced Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #9810
ref #9734 (comment)
This PR adds an ugly workaround for supporting cases in which
xgboost()is called with anxgb.DMatrixcontaining thelabelfield, since this used to work in previous versions.Note: I'm dropping the PR here in case we need it for compatibility. Not yet sure if it this would be good to merge.