Remove USE_COMPLEX_Z - #230
Open
quantumsteve wants to merge 7 commits into
Open
Conversation
quantumsteve
force-pushed
the
cleanup_dmrg_vbatch
branch
from
July 23, 2026 15:19
52cf5da to
bfa8eff
Compare
Collaborator
Author
|
@g1257 What in dmrgpp decides if we are using the real or complex code? single or double precision? |
Collaborator
|
Complex is using only if either of the following conditions is met
(1) usecomplex is in SolverOptions in the input, or
(2) TimeStepTargeting is in SolverOptions
See https://github.com/dmrgpp-project/dmrgpp/blob/master/dmrg/Engine/DmrgRunner.cpp#L70
If neither condition is met, then double is used.
|
Collaborator
Author
OK, so instantiating both real and complex makes sense. |
Collaborator
|
Yes, instantiating both real and complex makes sense.
|
Collaborator
|
This looks good to me but I would like to at least get a Magma CI environment ready and do a little testing on this. Whether the new CI flavor gets commit before or after is probably less crucial. |
masterleinad
approved these changes
Jul 27, 2026
quantumsteve
force-pushed
the
cleanup_dmrg_vbatch
branch
from
July 27, 2026 18:53
18f7bff to
3c2b2ff
Compare
Signed-off-by: Steven Hahn <hahnse@ornl.gov>
Signed-off-by: Steven Hahn <hahnse@ornl.gov>
Signed-off-by: Steven Hahn <hahnse@ornl.gov>
Signed-off-by: Steven Hahn <hahnse@ornl.gov>
Signed-off-by: Steven Hahn <hahnse@ornl.gov>
Signed-off-by: Steven Hahn <hahnse@ornl.gov>
Signed-off-by: Steven Hahn <hahnse@ornl.gov>
masterleinad
force-pushed
the
cleanup_dmrg_vbatch
branch
from
July 30, 2026 14:11
3c2b2ff to
3e5ff4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the
USE_COMPLEX_Zmacro, building bothdoubleandstd::complex<double>instantiations of each function. This also eliminatesMYTYPEandMAGMA_Tmacros.I also removed the
USE_MALLOCmacro and code contained asdmrg_mallocanddmrg_freedo the same thing.Lastly, I fixed some memory allocations preventing the batched plugin from working on multiple GPUs.