Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UT #55

Merged
merged 1 commit into from
Feb 20, 2020
Merged

Fix UT #55

merged 1 commit into from
Feb 20, 2020

Conversation

928PJY
Copy link
Collaborator

@928PJY 928PJY commented Feb 20, 2020

and use assert instead of chai since it cannot handle error equality, will remove all chai usage in the next PR: chaijs/chai#1065

@codecov-io
Copy link

Codecov Report

Merging #55 into master will decrease coverage by 2.36%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
- Coverage   90.75%   88.38%   -2.37%     
==========================================
  Files          15       21       +6     
  Lines         530      689     +159     
  Branches       40       52      +12     
==========================================
+ Hits          481      609     +128     
- Misses         39       66      +27     
- Partials       10       14       +4
Flag Coverage Δ
#component 71.46% <100%> (?)
#unit 90.75% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/credential/credentialController.ts 91.57% <100%> (ø)
src/common/uriEventHandler.ts 100% <0%> (ø)
src/shared.ts 88.88% <0%> (ø)
src/error/timeOutError.ts 100% <0%> (ø)
src/utils/utils.ts 41.66% <0%> (ø)
src/config.ts 100% <0%> (ø)
src/common/loggingEvents.ts 96.58% <0%> (+2.56%) ⬆️
src/credential/keyChain.ts 80.76% <0%> (+11.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0175f6d...8403e98. Read the comment docs.

@928PJY 928PJY merged commit e937367 into docascode:master Feb 20, 2020
@928PJY 928PJY deleted the fixUT branch February 20, 2020 02:22
928PJY added a commit that referenced this pull request Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants