Skip to content

Example :: DCLint GitHub Action :: reviewdog action #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/dclint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: docker-compose-linter/[email protected]
- name: dclint
uses: docker-compose-linter/dclint-github-action/[email protected]
with:
path: .
recursive: true
reporter: 'github-pr-review'
38 changes: 19 additions & 19 deletions docker-compose.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,23 @@
name: Test Compose
version: '3.9'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [dclint] <no-version-field> reported by reviewdog 🐶
The "version" field should not be present.

reviewdog suggestion errorsource line (L=0) is not available for this suggestion

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [dclint] <require-project-name-field> reported by reviewdog 🐶
The "name" field should be present.


services:
b-service:
build:
context: ../../app/b-service
dockerfile: Dockerfile
target: builder
args:
- TEST1=${TEST}
- TEST2=${TEST}
container_name: b-service
depends_on:
- c-service
volumes:
- ../../app/flexible-forms-client/:/var/www/app
- /var/www/app/node_modules
ports:
- '127.0.0.1:11131:3000'
command: sh -c "npm run start"
a-service:
build:
context: ../../tests/a-service
Expand All @@ -22,24 +39,7 @@ services:
- '127.0.0.1:11032:3000'
command: sh -c "tail -f /dev/null"
expose:
- '3000'
b-service:
build:
context: ../../app/b-service
dockerfile: Dockerfile
target: builder
args:
- TEST1=${TEST}
- TEST2=${TEST}
container_name: b-service
depends_on:
- c-service
volumes:
- ../../app/flexible-forms-client/:/var/www/app
- /var/www/app/node_modules
ports:
- '127.0.0.1:11131:3000'
command: sh -c "npm run start"
- 3000

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [dclint] <require-quotes-in-ports> reported by reviewdog 🐶
Ports in ports and expose sections should be enclosed in quotes.

reviewdog suggestion errorsource line (L=0) is not available for this suggestion

c-service:
build:
context: ../../tests/c-service
Expand Down