Skip to content

Add MariaDB support #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add MariaDB support #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1de5b90
Add DBMS parameter to .env-sample for DBMS flavor selection
jacobsyentl Jul 30, 2021
64d0f2d
Change mysql image URL to include the DBMS parameter + add fallback
jacobsyentl Jul 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions .env-sample
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,20 @@ BASEHOST=pimcore.docker
EXTRAHOSTS=www.pimcore.docker

#
#Choose whether you want to use mariadb or mysql depending on the server setup of your project.
#Rule of thumb = Mariadb is preffered when using >PimcoreX
#
DBMS=mysql
#DBMS=mariadb

# Choose your MySQL version. To see which versions are available see
# https://github.com/docker-library/mysql
#
# In case you use mariadb, check the tags on docker:
# https://hub.docker.com/_/mariadb?tab=tags&page=1&ordering=last_updated
#
MYSQLVERSION=8

# Choose whatever you want to use as default mysql root password.
#
MYSQL_ROOT_PASSWORD=toor
Expand All @@ -56,12 +70,6 @@ APPLICATION=../pimcore
#
DEVELOPMENT=1

#
# Choose your MySQL version. To see which versions are available see
# https://github.com/docker-library/mysql
#
MYSQLVERSION=8

#
# Set the default window manager when running the environment
# Available options are: tmux, screen and byobu
Expand Down
2 changes: 1 addition & 1 deletion docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ services:
- DOMAIN_NAME=redis.${BASEHOST:-pimcore.docker}

mysql:
image: docker.io/library/mysql:${MYSQLVERSION:-8}
image: docker.io/library/${DBMS:-mysql}:${MYSQLVERSION:-8}
environment:
- MYSQL_ROOT_PASSWORD=${MYSQL_ROOT_PASSWORD:-toor}
- DOMAIN_NAME=mysql.${BASEHOST:-pimcore.docker}
Expand Down