wallet-server: support local PEM key for mint-jwt.js - #63
Merged
Conversation
Add --key-file (and MCP_JWT_PRIVATE_KEY_FILE) as a dev-only alternative to AWS Secrets Manager, so JWTs can be minted without an AWS account. Also fixes a stale generate-keypair.js hint that referenced an env var mint-jwt.js never read.
Pre-existing on master (unrelated to the mint-jwt change on this branch) but blocked the pre-push audit hook. npm audit fix resolved all three without any manual overrides needed.
AgneCaunt
self-requested a review
August 11, 2026 14:40
AgneCaunt
previously approved these changes
Aug 11, 2026
CVE-2026-69152 bypasses the CVE-2026-14257 fix that brace-expansion@2.1.3 was pinned to (flagged as a new Trivy finding on PR #63, unrelated to that PR's actual change). 2.1.4 fixes both CVEs outright and still satisfies minimatch@9's ^2.0.2 requirement, so drop the now-stale .trivyignore entry and ACCEPTED_RISK grouping for it instead of re-justifying the risk.
AgneCaunt
self-requested a review
August 11, 2026 15:26
AgneCaunt
approved these changes
Aug 11, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--key-file(andMCP_JWT_PRIVATE_KEY_FILE) tomint-jwt.jsas a dev-only alternative to AWS Secrets Manager, so JWTs can be minted locally without an AWS account — mutually exclusive with--secret.generate-keypair.jshint that told users to setMCP_JWT_PRIVATE_KEY, an env varmint-jwt.jsnever actually read.npm audit fixforfast-uri/ip-address/nanoid— pre-existing on master, unrelated to the above, but the pre-push hook's production-dependency audit check blocked this branch on it.Test plan
node scripts/generate-keypair.jsstill prints a valid ES256 keypairnode scripts/mint-jwt.js <tenant> --key-file <path>mints and signs a valid JWT from a local PEM--secret+--key-filetogether, neither provided, nonexistent key filenpm run typecheckclean inapps/wallet-servernpm audit --omit=devno longer flags fast-uri/ip-address/nanoid; remaining fixable findings are already accepted-risk perscripts/check-audit.js🤖 Generated with Claude Code