fix: bridge PointerHolder<T> to std::shared_ptr<T> for qpdf 10.x +#221
Merged
PeterStaar-IBM merged 1 commit intodocling-project:mainfrom Feb 19, 2026
Conversation
…C 13+ GCC 13+ rejects the implicit conversion from qpdf 10.x's PointerHolder<T> to std::shared_ptr<T>. Add a to_shared_ptr() shim and apply it to all getRawStreamData()/getStreamData() call sites. Fixes docling-project#220 Signed-off-by: Lalatendu Mohanty <[email protected]>
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
Contributor
|
✅ DCO Check Passed Thanks @LalatenduMohanty, all your commits are properly signed off. 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC 13+ rejects the implicit conversion from qpdf 10.x's PointerHolder to std::shared_ptr. Add a to_shared_ptr() shim and apply it to all getRawStreamData()/getStreamData() call sites.
Fixes #220