fix: replace fixed-size utf8::append buffers with std::back_inserter to prevent segfaults#224
Merged
PeterStaar-IBM merged 8 commits intomainfrom Feb 20, 2026
Merged
Conversation
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
…to prevent segfaults Pre-allocated std::string buffers passed as output iterators to utf8::append and utf8::utf16to8 could overflow if the encoded UTF-8 exceeded the allocated size, causing segfaults. Replace all such patterns with std::back_inserter so the string grows dynamically as needed. Affected locations: cmap_value::codepoint_to_utf8, cmap_parser::to_utf8, cmap_parser::populate_range_mapping_legacy, and page_font encoding fallbacks (IDENTITY_H/V and CMAP_RESOURCES). Signed-off-by: Peter Staar <taa@zurich.ibm.com>
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
Contributor
|
✅ DCO Check Passed Thanks @PeterStaar-IBM, all your commits are properly signed off. 🎉 |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
PeterStaar-IBM
changed the title
cau-git
previously approved these changes
Feb 19, 2026
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
dolfim-ibm
previously approved these changes
Feb 19, 2026
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
dolfim-ibm
previously approved these changes
Feb 19, 2026
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
cau-git
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-allocated std::string buffers passed as output iterators to utf8::append
and utf8::utf16to8 could overflow if the encoded UTF-8 exceeded the allocated
size, causing segfaults. Replace all such patterns with std::back_inserter so
the string grows dynamically as needed.
Affected locations: cmap_value::codepoint_to_utf8, cmap_parser::to_utf8,
cmap_parser::populate_range_mapping_legacy, and page_font encoding fallbacks
(IDENTITY_H/V and CMAP_RESOURCES).
Resolves docling-project/docling#1531