fix: merge mixed-font symbols into line cells#230
Open
serge-medvedev wants to merge 2 commits intodocling-project:mainfrom
Open
fix: merge mixed-font symbols into line cells#230serge-medvedev wants to merge 2 commits intodocling-project:mainfrom
serge-medvedev wants to merge 2 commits intodocling-project:mainfrom
Conversation
Use the order-independent line merge path when building textline cells and disable same-font enforcement for line-cell merges. This prevents fallback-font symbols (for example arrows) from being emitted as standalone line cells when PDF content-stream order differs from visual order. Also make v2 line merging handle reverse adjacency symmetrically and add a targeted synthetic regression fixture/test that asserts the exact textline-cell output.
Contributor
|
✅ DCO Check Passed Thanks @serge-medvedev, all your commits are properly signed off. 🎉 |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
I, Serge Medvedev <thismoment.main@gmail.com>, hereby add my Signed-off-by to this commit: 81dbadb Signed-off-by: Serge Medvedev <thismoment.main@gmail.com>
PeterStaar-IBM
requested changes
Feb 24, 2026
| // Use the order-independent merge path for line construction and do not require font equality. | ||
| contract_cells_into_lines_v2(line_cells, | ||
| config.horizontal_cell_tolerance, | ||
| false, |
Member
There was a problem hiding this comment.
why would you hard code it if we have a config parameter for this?
Author
There was a problem hiding this comment.
Due to lack of understanding of the code base.
The bug surfaced in docling-serve and it took a bit of triage to dig this deep.
What about adding a new config option, e.g. decode_page_config.enforce_same_font_for_line_cells (as the existing one decode_page_config.enforce_same_font is too coarse)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the order-independent line merge path when building textline cells and disable same-font enforcement for line-cell merges. This prevents fallback-font symbols (for example arrows) from being emitted as standalone line cells when PDF content-stream order differs from visual order.
Also make v2 line merging handle reverse adjacency symmetrically and add a targeted synthetic regression fixture/test that asserts the exact textline-cell output.