Add checks for scheduled deletions in SortableListener#3034
Open
kov-lucas wants to merge 2 commits intodoctrine-extensions:mainfrom
Open
Add checks for scheduled deletions in SortableListener#3034kov-lucas wants to merge 2 commits intodoctrine-extensions:mainfrom
kov-lucas wants to merge 2 commits intodoctrine-extensions:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes issue #3009
In
processDeletion()Added an early check that skips position reorganization entirely if any entity is scheduled for deletion. There's no point reorganizing positions for items that are all about to be deleted anyway.
In
getMaxPosition()Extended the existing check to also detect when group entities are scheduled for deletion. This prevents queries from being built with deleted entities.