Skip to content

Conversation

savemetenminutes
Copy link

@greg0ire
Copy link
Member

I think the thing that actually needs to be refactor is

try {
$this->executeMigration(
$plan,
$result,
$configuration,
);
$result->setSql($this->sql);
} catch (SkipMigration $e) {
$result->setSkipped(true);
$this->migrationEnd($e, $plan, $result, $configuration);
} catch (Throwable $e) {
$result->setError(true, $e);
$this->migrationEnd($e, $plan, $result, $configuration);
throw $e;
}

You should do something similar to doctrine/orm#11646

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants