Conversation
✅ Deploy Preview for colander-cal ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
dogmar
force-pushed
the
fix/netlify-builds
branch
from
7df43a3 to
ef8d19d
Compare
Watches package/src/ and regenerates api-data/symbols.gen.json on changes. Runs on dev server startup and on file change. Fixes docs page crash when symbols.gen.json doesn't exist. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Use useSectionNav() hook (which safely searches via useMatches) instead of directly importing parent route and calling useLoaderData(), which returns undefined during server-side rendering. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The Tailwind v4 --spacing base variable enables a multiplier pattern that makes any w-N class valid, defeating our restricted spacing scale. Rename to --sp so only explicitly defined --spacing-N tokens are canonical. Also migrate inline var(--spacing) references to theme(spacing.N). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The Tailwind v4 --spacing base variable enables a multiplier pattern that makes any w-N class valid, defeating our restricted spacing scale. Rename to --sp so only explicitly defined --spacing-N tokens are canonical. Also migrate inline var(--spacing) references to theme(spacing.N). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Pre-generates per-file highlighted JSON (e.g. basic-calendar.highlighted.gen.json) at build time and watches src/examples/ during dev. ExampleBlock imports via import.meta.glob instead of receiving server-injected props. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replaces ts.transpileModule with ts-blank-space, which replaces type annotations with whitespace instead of re-emitting the code. This preserves the original file's line structure in the JS output. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Move all VITE_* environment variables into website/src/config.ts as plain TypeScript constants. Remove env.d.ts and .env gitignore entry. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
# Conflicts: # website/src/components/Header.tsx # website/src/components/SourceLink.tsx # website/src/components/ui/accordion.tsx # website/src/examples/date-picker-styled.tsx # website/src/routes/docs/index.tsx
dogmar
changed the title
The highlight-examples plugin imports typescript via strip-types.ts, but it was only available in the root package. CI installs per-package so website needs its own dependency. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@netlify/vite-plugin-tanstack-startandnetlify.tomlhighlight-examples(build-time syntax highlighting for code examples) andextract-api(dev-mode API symbol extraction), replacing the runtimeresolve-examplestree walkerts-blank-spacewith TypeScript's owntranspileModule— ts-blank-space has a bug where JSX spreads cause subsequent function-call attributes to be incorrectly blanked out.envvars (VITE_PROJECT_NAME, etc.) into a checked-inwebsite/src/config.ts, removing.env/.env.example/env.d.ts--spacingbase var (--sp), canonical class warnings, and Tailwind spacing referencesTest plan
vp run readypasses (lint, format, all tests, no build warnings)🤖 Generated with Claude Code