-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support in operator #364
Conversation
WalkthroughThe pull request introduces support for Changes
Poem
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/sdk/src/queryBuilder.ts (1)
150-155
: Double-check consistency of$nin
usage.
The methodnotIn
provides an exclusion-based filter. Similar toin
, ensure it's clear thatvalue
should be an array to reduce confusion.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
packages/sdk/src/convertQuerytoClause.ts
(1 hunks)packages/sdk/src/queryBuilder.ts
(2 hunks)
🔇 Additional comments (3)
packages/sdk/src/queryBuilder.ts (2)
143-148
: Ensure value
is correctly typed for $in
operations.
While the logic matches the intended functionality, $in
queries typically expect an array or similar iterable. Consider runtime validation or more specific typing to help users avoid passing non-iterable values.
194-195
: Enumerations for $in
and $nin
are a welcome addition.
Expanding the Operator
enum to include $in
and $nin
is aligned with standard query semantics. Good job!
packages/sdk/src/convertQuerytoClause.ts (1)
316-319
: Mappings for $in
and $nin
appear correct.
The Torii "In" / "NotIn" mapping is logical and completes the integration. Confirm that downstream logic handles these operators as expected (e.g., checking for arrays).
Closes #
Introduced changes
Checklist
Summary by CodeRabbit
$in
and$nin
query operatorsin()
andnotIn()
for more flexible querying