-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dojo-lang): use PluginDiagnostic instead of panic for model keys verification #1327
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1327 +/- ##
==========================================
- Coverage 64.27% 64.27% -0.01%
==========================================
Files 229 229
Lines 19711 19708 -3
==========================================
- Hits 12669 12667 -2
+ Misses 7042 7041 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i forgot to mention in the initial review, but let's include a test for the new behaviour in here also. Then, we're good to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing. Sorry for not putting them at the first round.. Thank you again. 👍
@kariy suggested the use of PluginDiagnostics, which enhance the debug experience:
Also, the error handling is now done by
model.rs
instead of being done inside theIntrospect
handling.Happy to have feedback on the wording if it needs to be adjusted. 👍