Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add database version file for katana-db #1338

Merged
merged 2 commits into from
Dec 28, 2023
Merged

Conversation

kariy
Copy link
Member

@kariy kariy commented Dec 28, 2023

Adds a version file when creating a new DB. Serves as a way to introduces versioning to the DB. This is to ensure that changes made to the DB (eg tables) can be tracked in order to maintain compatibility with its provider implementations.

@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (1a6d1ce) 64.63% compared to head (cf3af20) 65.33%.
Report is 2 commits behind head on main.

Files Patch % Lines
crates/katana/storage/db/src/lib.rs 91.04% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1338      +/-   ##
==========================================
+ Coverage   64.63%   65.33%   +0.69%     
==========================================
  Files         229      228       -1     
  Lines       19722    19620     -102     
==========================================
+ Hits        12747    12818      +71     
+ Misses       6975     6802     -173     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kariy kariy merged commit dfc48d0 into dojoengine:main Dec 28, 2023
9 checks passed
@kariy kariy deleted the db-version branch December 28, 2023 12:49
Larkooo pushed a commit that referenced this pull request Jan 2, 2024
* add db version file

* add more test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants