Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release: v1.1.0 #2958

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Prepare release: v1.1.0 #2958

merged 1 commit into from
Jan 28, 2025

Conversation

tarrencev
Copy link
Contributor

@tarrencev tarrencev commented Jan 28, 2025

Automated changes by create-pull-request GitHub action

Summary by CodeRabbit

  • Version Update
    • Incremented version from 1.0.12 to 1.1.0 across multiple project files:
      • Workspace package
      • Dojo core package
      • Torii types-test package
      • Spawn-and-move example package

Copy link

coderabbitai bot commented Jan 28, 2025

Walkthrough

Ohayo, sensei! This pull request involves a version bump across multiple Rust project configuration files. The workspace and several crates have been updated from version 1.0.12 to 1.1.0, indicating a coordinated release increment. This change appears to be a standard version update that synchronizes the version number across different components of the project.

Changes

File Change Summary
Cargo.toml Version updated from 1.0.12 to 1.1.0 in workspace package
crates/dojo/core/Scarb.toml Package version updated from 1.0.12 to 1.1.0
crates/torii/types-test/Scarb.toml Package version updated from 1.0.12 to 1.1.0
examples/spawn-and-move/Scarb.toml Package version updated from 1.0.12 to 1.1.0

Possibly related PRs

Suggested reviewers

  • glihm

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fb772c8 and 591a6ce.

⛔ Files ignored due to path filters (4)
  • Cargo.lock is excluded by !**/*.lock
  • crates/dojo/core/Scarb.lock is excluded by !**/*.lock
  • crates/torii/types-test/Scarb.lock is excluded by !**/*.lock
  • examples/spawn-and-move/Scarb.lock is excluded by !**/*.lock
📒 Files selected for processing (4)
  • Cargo.toml (1 hunks)
  • crates/dojo/core/Scarb.toml (1 hunks)
  • crates/torii/types-test/Scarb.toml (1 hunks)
  • examples/spawn-and-move/Scarb.toml (1 hunks)
✅ Files skipped from review due to trivial changes (2)
  • crates/dojo/core/Scarb.toml
  • crates/torii/types-test/Scarb.toml
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: fmt
🔇 Additional comments (2)
examples/spawn-and-move/Scarb.toml (1)

4-4: Ohayo sensei! Version bump looks good! ✨

The version update to "1.1.0" aligns perfectly with the release preparation objectives.

Cargo.toml (1)

60-60: Ohayo sensei! Workspace version bump looks good! 🎉

The version update to "1.1.0" in the workspace package section is consistent with the release preparation.

Let's verify version consistency across all workspace members with this script:

✅ Verification successful

Ohayo sensei! Version inheritance is perfect! 🎉

All workspace members properly inherit the version "1.1.0" from the root workspace package, ensuring consistent versioning across the entire project.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check version consistency across all workspace members
# Look for any Cargo.toml files that might have their own version field

echo "Checking version consistency across workspace members..."
rg -g 'Cargo.toml' '^version\s*=' --no-heading

Length of output: 198


Script:

#!/bin/bash
# Check workspace configuration and members
echo "=== Workspace Configuration ==="
rg -A 5 '^\[workspace\]' Cargo.toml

echo -e "\n=== Looking for member Cargo.toml files ==="
fd Cargo.toml

Length of output: 2259


Script:

#!/bin/bash
# Check for version fields in member crates
echo "=== Checking for version fields in member crates ==="
# Exclude root Cargo.toml and search for version fields
fd Cargo.toml -E ./Cargo.toml -x rg -l '^version\s*=' {}

Length of output: 188


Script:

#!/bin/bash
# Check for version fields in member crates using find
echo "=== Checking for version fields in member crates ==="
find . -name "Cargo.toml" ! -path "./Cargo.toml" -type f -exec grep -l "^version\s*=" {} \;

echo -e "\n=== Showing version entries if found ==="
find . -name "Cargo.toml" ! -path "./Cargo.toml" -type f -exec grep "^version\s*=" {} \;

Length of output: 398


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.71%. Comparing base (fb772c8) to head (591a6ce).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2958   +/-   ##
=======================================
  Coverage   56.71%   56.71%           
=======================================
  Files         420      420           
  Lines       55557    55557           
=======================================
+ Hits        31507    31508    +1     
+ Misses      24050    24049    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glihm glihm merged commit 25ec117 into main Jan 28, 2025
15 checks passed
@glihm glihm deleted the prepare-release branch January 28, 2025 03:04
@coderabbitai coderabbitai bot mentioned this pull request Jan 28, 2025
@coderabbitai coderabbitai bot mentioned this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants