fix(katana): data gas prices

[augustin-v]

Description

fixes the value passed as data_gas_prices

Tests

• Yes
• [☑️ ] No, because they aren't needed
• No, because I need help

Added to documentation?

• README.md
• Dojo Book
• [ ☑️ ] No documentation needed

Checklist

• [ ☑️ ] I've formatted my code (scripts/prettier.sh, scripts/rust_fmt.sh, scripts/cairo_fmt.sh)
• [ ☑️ ] I've linted my code (scripts/clippy.sh, scripts/docs.sh)
• I've commented my code
• I've requested a review after addressing the comments

Summary by CodeRabbit

• New Features
  • Introduced a refined fee calculation approach where data transaction fees are determined separately from regular fees. This adjustment provides more accurate and predictable fee estimates for end-users during transaction processing.

[coderabbitai]

Ohayo, sensei!

Walkthrough

This update modifies the gas pricing logic in the block_context_from_envs function within the executor module. Two new variables—strk_l1_data_gas_price and eth_l1_data_gas_price—are introduced to capture data transaction gas prices. They are initialized from block_env.l1_data_gas_prices with a fallback value of 1 when the provided value is zero. The gas_prices structure is updated accordingly to treat data gas prices as distinct from regular gas prices.

Changes

File	Change Summary
crates/katana/.../blockifier/utils.rs	Added variables strk_l1_data_gas_price and eth_l1_data_gas_price in block_context_from_envs with a default fallback of 1 if the original values are zero; updated gas_prices structure.

Sequence Diagram(s)

sequenceDiagram
    participant Caller as Caller
    participant BFunc as block_context_from_envs
    participant Env as block_env.l1_data_gas_prices
    participant Gas as GasPrices Struct

    Caller->>BFunc: Invoke block_context_from_envs()
    BFunc->>Env: Retrieve l1_data_gas_prices (strk, eth)
    Env-->>BFunc: Return gas price values
    alt Price value equals 0
      BFunc->>BFunc: Set data gas price to default (1)
    else Price value exists
      BFunc->>BFunc: Use provided gas price value
    end
    BFunc->>Gas: Update gas_prices structure with new data gas price values
    BFunc-->>Caller: Return updated block context

Loading

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d11a7ec and 66a33d1.

📒 Files selected for processing (1)

• crates/katana/executor/src/implementation/blockifier/utils.rs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: ensure-wasm
• GitHub Check: build
• GitHub Check: docs

🔇 Additional comments (2)

crates/katana/executor/src/implementation/blockifier/utils.rs (2)

398-401: Ohayo! The data gas price initialization looks good, sensei!

The implementation follows the established pattern, using NonZeroU128 with appropriate fallback values.

---

406-407: The gas prices struct update is well implemented, sensei!

The changes correctly integrate the new data gas price variables into the GasPrices struct, aligning with the PR's objective to fix data gas prices.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.10%. Comparing base (99d2e60) to head (66a33d1).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3001      +/-   ##
==========================================
- Coverage   57.14%   57.10%   -0.04%     
==========================================
  Files         429      429              
  Lines       56834    56871      +37     
==========================================
- Hits        32477    32476       -1     
- Misses      24357    24395      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.