Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(torii): token id column in tokens table for erc721 #3008

Merged
merged 3 commits into from
Feb 12, 2025

Conversation

Larkooo
Copy link
Collaborator

@Larkooo Larkooo commented Feb 11, 2025

Summary by CodeRabbit

  • New Features
    • Introduced a new token identifier field within token records to support additional token types.
    • Enhanced query performance with the addition of an index on the new token identifier field.
    • Updated database insertion processes to incorporate the token identifier seamlessly.

Copy link

coderabbitai bot commented Feb 11, 2025

Walkthrough

Ohayo sensei! This update introduces a new token_id column in the tokens table along with an index on that column. The corresponding SQL migration file defines these schema changes. Additionally, the SQL query in the handle_erc721_token_metadata method (in the SQLite executor) has been updated to include the new token_id field in the insertion process.

Changes

File Change Summary
crates/torii/migrations/.../20250211143225_token_id.sql Added token_id TEXT NULL to the tokens table and created index idx_token_id.
crates/torii/sqlite/src/executor/erc.rs Modified the handle_erc721_token_metadata SQL query to include the token_id field and updated the binding to insert actual_token_id accordingly.

Sequence Diagram(s)

sequenceDiagram
    participant U as User Request
    participant E as Executor (handle_erc721_token_metadata)
    participant DB as Database

    U->>E: Submit token metadata registration
    E->>DB: INSERT INTO tokens (id, contract_address, token_id, name, symbol, decimals, metadata)
    DB-->>E: Return insert confirmation
    E-->>U: Send confirmation response
Loading

Possibly related PRs

Suggested reviewers

  • glihm (sensei)

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6cf0603 and d15de99.

📒 Files selected for processing (1)
  • crates/torii/migrations/20250211143225_token_id.sql (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • crates/torii/migrations/20250211143225_token_id.sql
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: docs
  • GitHub Check: build
  • GitHub Check: ensure-wasm

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Larkooo Larkooo changed the title refactor(torii): tokens table contains token id for erc721 tokens refactor(torii): token id column in tokens table for erc721 Feb 11, 2025
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 56.60%. Comparing base (b8e5ebb) to head (d15de99).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
crates/torii/sqlite/src/executor/erc.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3008      +/-   ##
==========================================
- Coverage   56.62%   56.60%   -0.03%     
==========================================
  Files         431      432       +1     
  Lines       57637    57851     +214     
==========================================
+ Hits        32637    32745     +108     
- Misses      25000    25106     +106     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glihm glihm merged commit 70c59f6 into dojoengine:main Feb 12, 2025
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants