-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare release: v1.2.0 #3020
Prepare release: v1.2.0 #3020
Conversation
Ohayo sensei! Here’s the updated overview of the changes: WalkthroughThe pull request updates version numbers across multiple configuration files in a Rust project. Specifically, the version in the workspace and package definitions is incremented from "1.1.2" to "1.2.0". This update occurs in the main Changes
Sequence Diagram(s)(No sequence diagrams generated as there are no modifications to the control flow.) Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
This reverts commit 1ebd917.
8c91ef1
to
d007a8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
examples/simple/manifest_dev.json (1)
2007-2007
: New arrays initialized.Ohayo! The empty libraries and external_contracts arrays have been added to support future extensibility.
Consider adding documentation comments in the manifest to explain:
- The purpose and structure of the libraries array
- The intended use of external_contracts
Also applies to: 2036-2036
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (6)
crates/dojo/core-cairo-test/Scarb.lock
is excluded by!**/*.lock
crates/torii/types-test/Scarb.lock
is excluded by!**/*.lock
examples/simple/Scarb.lock
is excluded by!**/*.lock
examples/spawn-and-move/Scarb.lock
is excluded by!**/*.lock
spawn-and-move-db.tar.gz
is excluded by!**/*.gz
types-test-db.tar.gz
is excluded by!**/*.gz
📒 Files selected for processing (4)
examples/simple/manifest_dev.json
(11 hunks)examples/spawn-and-move/manifest_dev.json
(1 hunks)examples/spawn-and-move/src/actions.cairo
(3 hunks)examples/spawn-and-move/src/lib_math.cairo
(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
- examples/spawn-and-move/src/lib_math.cairo
- examples/spawn-and-move/src/actions.cairo
- examples/spawn-and-move/manifest_dev.json
🔇 Additional comments (5)
examples/simple/manifest_dev.json (5)
3-4
: LGTM! World configuration updated.Ohayo! The world contract's class_hash and address have been properly updated.
14-14
: Library support infrastructure looks good!Ohayo sensei! The addition of library support through the register_library entrypoint and Library Resource variant is well structured. The Library variant appropriately stores both the class_hash and a felt252 identifier.
Also applies to: 82-86
370-397
: Well-designed library registration interface!The register_library function interface is thoughtfully designed with:
- Namespace scoping for organization
- Version tracking for library evolution
- Name parameter for identification
- Returns class_hash for verification
1001-1022
: Library registration event properly structured!The LibraryRegistered event captures all essential information:
- name and namespace as keys for filtering/indexing
- class_hash as data for verification
1315-1315
: Contract addresses updated correctly.The contract addresses have been properly updated in the manifest.
Also applies to: 1573-1573, 1749-1749
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit
Chores
New Features
simple_math
library in the actions module.Bug Fixes
test
function from theSimpleMath
interface to streamline functionality.Refactor
decrement_saturating
method in theSimpleMath
module.