Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release: v1.2.0 #3020

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Prepare release: v1.2.0 #3020

merged 2 commits into from
Feb 13, 2025

Conversation

tarrencev
Copy link
Contributor

@tarrencev tarrencev commented Feb 13, 2025

Automated changes by create-pull-request GitHub action

Summary by CodeRabbit

  • Chores

    • Upgraded the project version to 1.2.0 across all components for a consistent and improved release.
  • New Features

    • Introduced a new method for library registration and added a corresponding event to track library registrations.
    • Added a new resource entry for the simple_math library in the actions module.
  • Bug Fixes

    • Removed the test function from the SimpleMath interface to streamline functionality.
  • Refactor

    • Simplified the implementation of the decrement_saturating method in the SimpleMath module.

Copy link

coderabbitai bot commented Feb 13, 2025

Ohayo sensei! Here’s the updated overview of the changes:

Walkthrough

The pull request updates version numbers across multiple configuration files in a Rust project. Specifically, the version in the workspace and package definitions is incremented from "1.1.2" to "1.2.0". This update occurs in the main Cargo.toml as well as in several Scarb.toml files within different project directories, with no other changes to dependencies or configurations.

Changes

File(s) Change Summary
Cargo.toml Updated [workspace.package] version from "1.1.2" to "1.2.0".
crates/dojo/core/Scarb.toml, crates/torii/types-test/Scarb.toml, examples/spawn-and-move/Scarb.toml Updated package version from "1.1.2" to "1.2.0" in their [package] sections.
examples/simple/manifest_dev.json Added new entry point, updated Resource enum, and modified abi section with new event and contract addresses.
examples/spawn-and-move/manifest_dev.json Updated class_hash and removed test function from SimpleMath interface.
examples/spawn-and-move/src/actions.cairo Added import for simple_math and expanded testing capabilities.
examples/spawn-and-move/src/lib_math.cairo Removed test method and simplified decrement_saturating method.

Sequence Diagram(s)

(No sequence diagrams generated as there are no modifications to the control flow.)

Possibly related PRs

Suggested reviewers

  • glihm

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@steebchen steebchen enabled auto-merge (squash) February 13, 2025 09:03
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
examples/simple/manifest_dev.json (1)

2007-2007: New arrays initialized.

Ohayo! The empty libraries and external_contracts arrays have been added to support future extensibility.

Consider adding documentation comments in the manifest to explain:

  • The purpose and structure of the libraries array
  • The intended use of external_contracts

Also applies to: 2036-2036

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8c91ef1 and d007a8c.

⛔ Files ignored due to path filters (6)
  • crates/dojo/core-cairo-test/Scarb.lock is excluded by !**/*.lock
  • crates/torii/types-test/Scarb.lock is excluded by !**/*.lock
  • examples/simple/Scarb.lock is excluded by !**/*.lock
  • examples/spawn-and-move/Scarb.lock is excluded by !**/*.lock
  • spawn-and-move-db.tar.gz is excluded by !**/*.gz
  • types-test-db.tar.gz is excluded by !**/*.gz
📒 Files selected for processing (4)
  • examples/simple/manifest_dev.json (11 hunks)
  • examples/spawn-and-move/manifest_dev.json (1 hunks)
  • examples/spawn-and-move/src/actions.cairo (3 hunks)
  • examples/spawn-and-move/src/lib_math.cairo (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
  • examples/spawn-and-move/src/lib_math.cairo
  • examples/spawn-and-move/src/actions.cairo
  • examples/spawn-and-move/manifest_dev.json
🔇 Additional comments (5)
examples/simple/manifest_dev.json (5)

3-4: LGTM! World configuration updated.

Ohayo! The world contract's class_hash and address have been properly updated.


14-14: Library support infrastructure looks good!

Ohayo sensei! The addition of library support through the register_library entrypoint and Library Resource variant is well structured. The Library variant appropriately stores both the class_hash and a felt252 identifier.

Also applies to: 82-86


370-397: Well-designed library registration interface!

The register_library function interface is thoughtfully designed with:

  • Namespace scoping for organization
  • Version tracking for library evolution
  • Name parameter for identification
  • Returns class_hash for verification

1001-1022: Library registration event properly structured!

The LibraryRegistered event captures all essential information:

  • name and namespace as keys for filtering/indexing
  • class_hash as data for verification

1315-1315: Contract addresses updated correctly.

The contract addresses have been properly updated in the manifest.

Also applies to: 1573-1573, 1749-1749

@steebchen steebchen disabled auto-merge February 13, 2025 10:37
@steebchen steebchen merged commit 0d4394f into main Feb 13, 2025
12 of 13 checks passed
@steebchen steebchen deleted the prepare-release branch February 13, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants