[statspro] Avoid copying histograms, perf improvement #7666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#benchmark |
|
@max-hoffman DOLT
|
|
@max-hoffman DOLT
|
|
@max-hoffman DOLT
|
|
@max-hoffman DOLT
|
|
@max-hoffman DOLT
|
|
@coffeegoddd DOLT
|
zachmu
approved these changes
Apr 2, 2024
|
|
||
| var _ sql.Statistic = (*DoltStats)(nil) | ||
|
|
||
| func (s *DoltStats) WithColSet(set sql.ColSet) sql.Statistic { |
There was a problem hiding this comment.
I'm not crazy about all this boilerplate code to avoid an embedding but I guess it's slightly preferable to this breaking silently when you add a new With method to the interface type
There was a problem hiding this comment.
the embedded version i started with did have confusing looking errors for missed Withs, so i switched to this one
| return &DoltStats{mu: &sync.Mutex{}, Active: make(map[hash.Hash]int), Statistic: &stats.Statistic{}} | ||
| } | ||
|
|
||
| func (s *DoltStats) ToInterface() interface{} { |
There was a problem hiding this comment.
This should probably be called JsonMap or similar and potentially have the return type map[string]any
There was a problem hiding this comment.
i think it can return a list of interfaces also, []interface{}. not for this type specifically, but the json interface this implements
…max/stats-struct-perf
|
@max-hoffman DOLT
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
companion: dolthub/go-mysql-server#2421