[no-release-notes] go: sqle/cluster: commithook: Create a sql session and make lifecycle callbacks when accessing srcDB. #8816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and make lifecycle callbacks when accessing srcDB. As part of GC safepoint establishment, we need lifecycle callbacks around all the places we access the database. This PR adds those callbacks to the cluster replication commithook. Lifecycle on registering the commit hooks on the database versus creating the SqlEngine instance is a little wonky. Concretely, we register the hooks before we create the SqlEngine, but we we change things so that we start running them after the SqlEngine is created and can supply the appropriate factory for the sql.Context.
|
@coffeegoddd DOLT
|
…ok-sql-session-lifecycle
max-hoffman
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of GC safepoint establishment, we need lifecycle callbacks around all the places we access the database. This PR adds those callbacks to the cluster replication commithook.
Lifecycle on registering the commit hooks on the database versus creating the SqlEngine instance is a little wonky. Concretely, we register the hooks before we create the SqlEngine, but we we change things so that we start running them after the SqlEngine is created and can supply the appropriate factory for the sql.Context.