Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[no-release-notes] fix bad tests and bump #8837

Merged
merged 2 commits into from
Feb 7, 2025
Merged

[no-release-notes] fix bad tests and bump #8837

merged 2 commits into from
Feb 7, 2025

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Feb 7, 2025 •
edited
Loading

The stored procedure was archive_order_history was never created anywhere, so this should've never worked.

max-hoffman
max-hoffman approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coffeegoddd
Copy link
Contributor

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
f8f3b8a ok 5937457
version total_tests
f8f3b8a 5937457
correctness_percentage
100.0

@jycor jycor merged commit 5b028a5 into main Feb 7, 2025
34 of 35 checks passed
@jycor jycor deleted the james/archive branch February 7, 2025 21:55
@jycor jycor mentioned this pull request Feb 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-hoffman max-hoffman max-hoffman approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jycor @coffeegoddd @max-hoffman