Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move status messages from parquet to stderr #8842

Merged
merged 9 commits into from
Feb 10, 2025
Merged

move status messages from parquet to stderr #8842

merged 9 commits into from
Feb 10, 2025

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Feb 10, 2025

fixes: #8839

@coffeegoddd
Copy link
Contributor

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
167cd9d ok 5937457
version total_tests
167cd9d 5937457
correctness_percentage
100.0

timsehn
timsehn reviewed Feb 10, 2025
View reviewed changes
Copy link
Contributor

@timsehn timsehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make a test :-)

@coffeegoddd
Copy link
Contributor

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
8671d13 ok 5937457
version total_tests
8671d13 5937457
correctness_percentage
100.0

fulghum
fulghum approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jycor jycor merged commit 2d8f6d4 into main Feb 10, 2025
21 checks passed
@jycor jycor deleted the james/print branch February 10, 2025 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timsehn timsehn timsehn left review comments

@fulghum fulghum fulghum approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dolt sql --result-format=parquet --file path.sql prints garbage to stdout
4 participants
@jycor @coffeegoddd @fulghum @timsehn