[no-release-notes] go: sqle: Change how we run background threads for replication hooks. Add session lifecycle callbacks for replication hooks. #8848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nitialization. Do not do it immediately when we create the hook itself, since at that time we may not have all the machinery in place to get the dependencies of the threads. Also moves the installation of the replication hook init database hook to a separate call on the DoltDatabaseProvider, instead of always installing those hooks.
…round interactions with DB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves aims to add session lifecycle callbacks to the async replication thread that each push-on-write replication database runs. In order to accomplish this, we move the initialization of those background threads to be later in the process of our construction of the SqlEngine. We also have to move the installation of the InitDatabaseHook which is responsible for setting up replication on newly created databases to be later in the initialization, as opposed to installing it immediately when we construct the DatabaseProvider.