Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP8 Compatibility: Annotate return types for jsonSerialize() implementations #106

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

PHP8 Compatibility: Annotate return types for jsonSerialize() implementations #106

wants to merge 1 commit into from

Conversation

dmf-janw
Copy link

@dmf-janw dmf-janw commented Dec 6, 2023

Starting with PHP 8, it is required to annotate the return type of jsonSerialize() methods for objects that implement \JsonSerializable.

Without this, one would run into the following fatal error (for example):

PHP Fatal error:  During inheritance of JsonSerializable: Uncaught Exception: Deprecated Functionality: Return type of Doofinder\Management\Model\Item::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in vendor/doofinder/doofinder/src/Management/Model/Item.php on line 91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dmf-janw