-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to 7.0.5 #109
Upgrade to 7.0.5 #109
Conversation
I have no idea why it's failing if I haven't changed the lockfile at all |
Maybe that's the problem. Look at the logs of CI:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea why it's failing if I haven't changed the lockfile at all
have you tried what they suggest in the "Details" of each failed run?
composer.lock
Outdated
@@ -823,50 +926,46 @@ | |||
}, | |||
{ | |||
"name": "phpunit/phpunit", | |||
"version": "5.7.27", | |||
"version": "5.5.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this downgrading?
composer.lock
Outdated
@@ -1207,21 +1306,21 @@ | |||
}, | |||
{ | |||
"name": "sebastian/exporter", | |||
"version": "2.0.0", | |||
"version": "1.2.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is downgrading too.
composer.lock
Outdated
@@ -1230,7 +1329,7 @@ | |||
"type": "library", | |||
"extra": { | |||
"branch-alias": { | |||
"dev-master": "2.0.x-dev" | |||
"dev-master": "1.3.x-dev" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also downgrading.
composer.lock
Outdated
}, | ||
{ | ||
"name": "symfony/yaml", | ||
"version": "v4.4.45", | ||
"version": "v3.4.47", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look at this branch: master...refs/heads/teo/test
All I have done is:
- Do the changes in CHANGELOG.md
- Update the version in composer.json file
- Run
composer update doofinder/php-doofinder
That's it. No need to change CI flow. All checks passed.
.github/workflows/ci.yml
Outdated
- name: Update composer dependencies | ||
run: composer update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this, the composer validate
is validating the composer.lock that is modified by composer update
, not the composer.lock that is in git. So it's not doing the proper validation. There will be failures checking the content hash of the lock file.
There's no need to do a composer update
every time in CI. We do a composer install
later already.
@teoortuno Of course, the old CI does NOT use the PHP versions it says it does. It was broken since it was created. Take a look at it, you'll see nowhere it sets the PHP version other than the CI flow title. |
Obviously it will work, it's just using the same version for every flow and it's the same version as the one used to generate the lockfile. |
D'oh! Yeah, good catch. But I still think that the |
So we can just do validate then update? |
Let me see |
It's failing now @teoortuno |
With the same error that made me put composer update before validate actually |
Run |
Fixes https://github.com/doofinder/support/issues/3171
Upgrade library version to 7.0.5
After this, the package needs to be updated in https://packagist.org/packages/doofinder/doofinder