[Repo Assist] Export SetProperties from Data.Type.Set and improve its documentation#44
Draft
github-actions[bot] wants to merge 1 commit intomainfrom
Draft
Conversation
SetProperties was defined but not exported, making it unusable by library consumers. This constraint alias bundles common set-theoretic identity facts (Union f '[] ~ f, Union '[] f ~ f, Union f f ~ f, plus their Unionable/Sortable/Nubable witnesses), which helps reduce boilerplate in function constraints. Also improves the Haddock comment (fixed a typo and expanded the explanation). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is a draft PR created by Repo Assist, an automated AI assistant.
Summary
SetPropertieswas already defined inData.Type.Setbut was not included in the module's export list, making it completely inaccessible to library users. This PR exports it and improves its Haddock comment.Changes
SetPropertiesfromData.Type.Set(added to the module export list).Motivation
SetProperties fbundles common set-theoretic identity constraints:Union f '[] ~ f/Union '[] f ~ f(identity laws for union with the empty set)Union f f ~ f(idempotency)SplitandUnionablewitnesses (which in turn provideSortableandNubablewitnesses)This is directly useful for reducing constraint boilerplate, as raised in issue #14. For example, a user can write
SetProperties yinstead of spelling outUnionable y '[],Sortable (y :++ '[]), andNubable (Sort (y :++ '[]))separately.Test Status
SetPropertiesis already defined and in use elsewhere in the codebase.Please run
stack testbefore merging to confirm.Relates to: #14
Warning
The following domain was blocked by the firewall during workflow execution:
downloads.haskell.org