Skip to content

Use hubs in SignalR: Move all code examples to app project vers 7.0 #28459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wadepickett opened this issue Feb 20, 2023 · 0 comments
Open
Assignees
Labels
doc-enhancement seQUESTered Identifies that an issue has been imported into Quest. SignalR Source - Docs.ms Docs Customer feedback via GitHub Issue

Comments

@wadepickett
Copy link
Contributor

wadepickett commented Feb 20, 2023

This doc has a lot of inline code samples. Move the code to an app project and verify updated to 7.0.

A heads up that the scope of this work is a bit on the larger side and I will not know exactly how big until I get well into it:

  • In some cases the code snippets have been written in the doc as minimal general examples but not compliable code, such as missing required params or other required items expected within the method in order to work within an app sample.

  • The code samples span the following client types and differing hub server+client scenarios:
    *.NET Client
    *Typescript client
    *Java client

  • The context of how some of the snippets were supposed work in a larger app scenario are missing in places and the code out of date.

It is possible that for this issue/step, I may need to just add what is needed to the snippets to compile, add what would be expected in the methods to work and create compliable snippet hub classes, reviewed by the dev team. This appears to be the route already taken with some other hub class samples on the samples repo. Then as the dev team is able to take time with me to work out full client + Hub app samples for those scenarios as they intended to work, we can get additional app samples for those scenarios added to the samples repo.

Related to issue #27996


Document Details

Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.


Associated WorkItem - 64677

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-enhancement seQUESTered Identifies that an issue has been imported into Quest. SignalR Source - Docs.ms Docs Customer feedback via GitHub Issue
Projects
No open projects
Status: No status
Development

No branches or pull requests

2 participants