Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains following changes.
What's changed in this PR.
1. Enable CommandLineParser's
AllowMultiInstanceoptionThis option is introduced at CommandLineParser v2.9.1.
By enable this option, it can specify same options multiple times (e.g.
--filter A --filter Binstead of--filter A B)2. Modify
CommandLineOptions.csand add additional option mappings.Add following dictionary/hashSet definitions.
To avoid using reflection.
These mappings are manually edited (And mappings consistencies are validated by unit tests)
3. Modify
ConfigParser.csand add validation logics for duplicated scalar options.By default, when scalar option are specified multiple times. It's overwritten by last parameter.
To keep existing behavior, add logics to validate these cases.
4. Add ConfigParser related tests.