Skip to content

Merge v2.13 to main - #1129

Merged
AArnott merged 12 commits into
mainfrom
v2.13-to-main
Jul 27, 2026
Merged

Merge v2.13 to main#1129
AArnott merged 12 commits into
mainfrom
v2.13-to-main

Conversation

@AArnott

@AArnott AArnott commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

AArnott and others added 10 commits July 24, 2026 17:02
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This will avoid github API rate throttling for OSS repos that use nuget.org as their package feed.
…t crash

The Process.Exited event fires as soon as the child process terminates, but
OutputDataReceived/ErrorDataReceived callbacks can still fire afterward while
the OS pipe buffers are being drained. Previously, the test awaited only the
process exit, so the test method could return (and xunit could deactivate the
TestOutputHelper) before all output was consumed. Late-arriving output then
called logger.WriteLine() with no active test, causing xunit v3's strict
TestOutputHelper to throw InvalidOperationException on a threadpool thread,
crashing the test host process (exit code 7).

This was exposed by the upgrade from xunit.runner.visualstudio (VSTest) to
xunit.v3.mtp-v2 (MTP v2), which enforces that QueueTestOutput is only called
while a test is active.

Fix: track stdout/stderr EOF via TaskCompletionSources (signaled when
e.Data is null) and wait for both stream completions in addition to the
process exit before returning from the test.
@AArnott
AArnott enabled auto-merge July 27, 2026 18:04
AArnott and others added 2 commits July 27, 2026 12:38
@AArnott
AArnott added this pull request to the merge queue Jul 27, 2026
Merged via the queue into main with commit 261d7a0 Jul 27, 2026
14 checks passed
@AArnott
AArnott deleted the v2.13-to-main branch July 27, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant