Remove usage of Newtonsoft.Json in favor of System.Text.Json #1932
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces Newtonsoft.Json with System.Text.Json throughout the codebase. The changes were focused on:
Updating test files:
test/DocumentFormat.OpenXml.Packaging.Tests/PartConstraintRuleTests.cs
to use System.Text.Json for deserializationtest/DocumentFormat.OpenXml.Packaging.Tests/ParticleTests.cs
with custom converters for System.Text.JsonUpdating generator models:
gen/DocumentFormat.OpenXml.Generator.Models/Converters/QualifiedNameConverter.cs
to use System.Text.Json's converter patterngen/DocumentFormat.OpenXml.Generator.Models/Converters/TypedQNameConverter.cs
to use System.Text.Json's converter patterngen/DocumentFormat.OpenXml.Generator.Models/OpenXmlGeneratorDataSource.cs
to use System.Text.Json for deserializationPackage references:
gen/DocumentFormat.OpenXml.Generator.Models/DocumentFormat.OpenXml.Generator.Models.csproj
to reference System.Text.JsonThe PR maintains backward compatibility but ensures all code now uses System.Text.Json serialization and deserialization mechanisms.
Fixes #1931.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
crl3.digicert.com
dotnet build
(dns block)crl4.digicert.com
dotnet build
(dns block)ocsp.digicert.com
dotnet build
(dns block)s.symcb.com
dotnet build
(dns block)s.symcd.com
dotnet build
(dns block)ts-crl.ws.symantec.com
dotnet build
(dns block)ts-ocsp.ws.symantec.com
dotnet build
(dns block)/home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js
(dns block)www.microsoft.com
dotnet build
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.