Align comments by removing typos and small adjustments between netfx and netcore #2956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardneal
reviewed
Nov 2, 2024
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs
Outdated
Show resolved
Hide resolved
…moving typos and small adjustments between netfx and netcore
benrr101
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
No concerns with this one. Though two comments:
- This PR could have been included in the previous one that addressed aligning comment blocks
- I'll be waiting on the feedback on the aforementioned PR to see what the consensus is on removing linkages to old bug tracking systems.
benrr101
added
the
Common Project 🚮
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2956 +/- ##
=======================================
Coverage 72.31% 72.31%
=======================================
Files 288 288
Lines 59660 59660
=======================================
+ Hits 43145 43146 +1
+ Misses 16515 16514 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Rolled into #2955 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This purely tackles comments so it's hopefully easy to review. Mostly small typos, removal of obsolete information in comments or slightly changing where the comment appears to align netfx and netcore
Part of #2953