Tests | Fix RemoteCertificateNameMismatchErrorTest (ActiveIssue 31754) #3059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not automatically trust the Certificate in the Test
paulmedynski
approved these changes
Mar 18, 2025
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3059 +/- ##
==========================================
- Coverage 72.68% 66.17% -6.51%
==========================================
Files 283 282 -1
Lines 58975 59217 +242
==========================================
- Hits 42864 39186 -3678
- Misses 16111 20031 +3920
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes to the configuration and testing of SQL Server certificates. The most important changes involve adding a PowerShell script to configure SQL Server certificates on Windows and updating tests to reflect these changes.
Configuration changes:
eng/pipelines/common/templates/steps/configure-sql-server-win-step.yml: Added a PowerShell script to create a self-signed certificate, add it to trusted roots, and configure SQL Server instances to use the certificate. This script also grants read access to the private key for the SQL Service Account.Test updates:
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ConnectionTestWithSSLCert/CertificateTest.cs: Removed theActiveIssueattribute from theRemoteCertificateNameMismatchErrorTestmethod to enable the test.src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ConnectionTestWithSSLCert/CertificateTest.cs: Updated theRemoteCertificateNameMismatchErrorTestmethod to setTrustServerCertificatetofalse, ensuring the test checks for certificate name mismatches.This is in addition to #3012 which activates other tests in this Class