Skip to content

[5.2] Preserve distributed transactions on pooled connection reset #3113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: release/5.2
Choose a base branch
from

Conversation

mdaigle
Copy link
Contributor

@mdaigle mdaigle commented Jan 15, 2025

No description provided.

@mdaigle
Copy link
Contributor Author

mdaigle commented Jan 30, 2025

Waiting for 7.0-preview1 to ensure no regression with this change.

paulmedynski
paulmedynski previously approved these changes Mar 17, 2025
@paulmedynski paulmedynski self-assigned this Mar 21, 2025
samsharma2700
samsharma2700 previously approved these changes May 1, 2025
@benrr101
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@paulmedynski paulmedynski added this to the 5.2.4 milestone Jul 16, 2025
@mdaigle mdaigle dismissed stale reviews from samsharma2700 and paulmedynski via da47670 July 23, 2025 17:56
[ConditionalFact(nameof(s_EnlistedTransactionPreservedWhilePooledCondition), Timeout = 10000)]
public void Test_EnlistedTransactionPreservedWhilePooled()
{
#if NET7_0_OR_GREATER
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be just #NET ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case we need it because TransactionManager.ImplicitDistributedTransaction was introduced in .NET 7.0
https://learn.microsoft.com/en-us/dotnet/api/system.transactions.transactionmanager.implicitdistributedtransactions?view=net-7.0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, backporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants