Merge | LocalDBAPI

[benrr101]

This is a replacement of #3047 that will give us the complete CI

Description: This is one more PR that targets merging another file between the netfx project and the netcore project. This time, it's the LocalDBAPI. This one was a bit complicated because the files were split differently between netfx and netcore. The way I approached it was to merge the operative code into the LocalDBAPI.Windows file and merge the inoperative code to the LocalDBAPI.Unix file. The Windows file will be pulled in on both netfx and netcore projects, with it being conditionally included on netcore if the build is for Windows. The Unix file will be pulled in on netcore only, being conditionally included if the build is for Unix. Otherwise, this is a fairly standard merge with netfx having extra stuff that is #if'd in.

please note: cleanup to remove monitor sections, etc, is coming in a later PR.

Testing: There miiiiight be some issues with unix build, I might not have fully vetted it on unix.

[mdaigle]

I think this is a change in behavior, but I agree with it. Right now, we try to get the local db instance name for unix, and may return a non-null value, but later steps can fail with a PlatformNotSupportedException.

[benrr101]

On second look, yes I think you're right that it's a behavior change. I think the one thing I'm not sure about is if this will raise a platformnotsupported exception or if it will just fail to connect. I'm going to fire this up on linux to verify.

[benrr101]

Can confirm, on Linux, the behavior is the same - we get the "LocalDB is not supported on this platform" exception when trying to connect.

[codecov]

Codecov Report

Attention: Patch coverage is 24.71910% with 67 lines in your changes missing coverage. Please review.

Project coverage is 72.84%. Comparing base (17cb0b0) to head (bc3857d).
Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
...src/Microsoft/Data/SqlClient/LocalDBAPI.Windows.cs	23.86%	67 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3163      +/-   ##
==========================================
- Coverage   72.96%   72.84%   -0.12%     
==========================================
  Files         283      282       -1     
  Lines       58997    59175     +178     
==========================================
+ Hits        43048    43107      +59     
- Misses      15949    16068     +119     

Flag	Coverage Δ
addons	92.58% <ø> (ø)
netcore	75.48% <15.51%> (-0.25%)	⬇️
netfx	71.23% <24.41%> (-0.13%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.