Complete removal of SQL 2000 support #3217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…helZ/SqlClient into pr/tdsparser-remove-sql-2000
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlInternalConnectionSmi.cs
Show resolved
Hide resolved
paulmedynski
requested changes
Mar 14, 2025
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlConnection.cs
Show resolved
Hide resolved
| } | ||
| finally | ||
| { | ||
| if (con != null) |
There was a problem hiding this comment.
Can you add braces here, or use null-conditional con?.Dispose() ?
There was a problem hiding this comment.
Yes - fixed. I've updated the netcore code to keep it in sync.
paulmedynski
approved these changes
Mar 17, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3217 +/- ##
==========================================
- Coverage 72.58% 66.14% -6.44%
==========================================
Files 289 282 -7
Lines 59503 59203 -300
==========================================
- Hits 43188 39162 -4026
- Misses 16315 20041 +3726
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cheenamalhotra
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finishes the work from #3206 and prior PRs. It removes the
Is2005OrNewerandIs2000properties fromSqlCommand,SqlConnection,SqlInternalConnectionSmi,SqlInternalConnectionTds,SqlInternalConnectionandTdsParser, then chases those references through the codebase.I'd appreciate a CI run against this, although I don't think there'll be any surprises here - all of these code paths should be dead.