add string normalize method #1461
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alinpahontu2912
force-pushed
the
fix_dll_loading
branch
from
53cebf1 to
45c9c25
Compare
alinpahontu2912
force-pushed
the
fix_dll_loading
branch
from
45c9c25 to
587fa88
Compare
alinpahontu2912
commented
Mar 26, 2025
|
|
||
| var assembly = typeof(torch).Assembly; | ||
| var version = assembly.GetName().Version; | ||
| var torchSharpVersion = (version != null) ? version.ToString() : Path.GetFileName(torchsharpHome); |
There was a problem hiding this comment.
When taking the version string directly from the library it results in a 4 number version string: eg: 0.105.0.0, which needs to be normalized to remove last 0. I think it's better to have it taken straight from the dll that was loaded to the project than the nugget install folder.
Blackhex
reviewed
Mar 26, 2025
src/TorchSharp/Torch.cs
Outdated
| @@ -54,6 +54,26 @@ public static partial class torch | |||
| static bool nativeBackendCudaLoaded = false; | |||
|
|
|||
| public static string __version__ => libtorchPackageVersion; | |||
| private static string NormalizeNuGetVersion(string versionString) | |||
There was a problem hiding this comment.
Such function would deserve some unit tests as a documentation of expected behavior and as a validation. This would mean making it public so it would be better to move it to a separate class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated hardcoded string matching to fix dll loading in different scenarios, most commonly when trying to use TorchSharp in a .NET Interactive Notebook.