-
Notifications
You must be signed in to change notification settings - Fork 52
[.NET10] removal of generator generated code in Additions/ #1118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[.NET10] removal of generator generated code in Additions/ #1118
Conversation
…me warnings and errors
/azp run |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
obj/Controls.DeviceTests/Debug/net10.0-android/android/src/mono/androidx/recyclerview/widget/RecyclerView_ItemAnimator_ItemAnimatorListenerImplementor.java(8,57): javac error JAVAC0000: error: ItemAnimatorListener is not public in ItemAnimator; cannot be accessed from outside package
Warning : Dependency `platforms;android-36` should have been installed but could not be resolved. You can attempt to install it with...
javac.exe error JAVAC0000: error: BaseOnOffsetChangedListener cannot be inherited with different arguments: <com.google.android.material.appbar.AppBarLayout> and <>
Xamarin.Android.Javac.targets(161,5): error XAJVC0000: C:\a\_work\1\s\artifacts\obj\Benchmarks.Droid\Release\net10.0-android\android-arm64\android\src\mono\androidx\appcompat\widget\ActivityChooserModel_OnChooseActivityListenerImplementor.java:8: error: package androidx.appcompat.widget.ActivityChooserModel does not exist Xamarin.Android.Javac.targets(161,5): error XAJVC0000: androidx.appcompat.widget.ActivityChooserModel.OnChooseActivityListener Xamarin.Android.Javac.targets(161,5): error XAJVC0000: ^
I ran Then the powershell pipeline: Get-Item *.nupkg | ForEach-Object { Write-Output "apicompat package $_" ; & apicompat package $_.Name 2>&1 | ForEach-Object { "$_" } } > apidiff.txt Which results in ~452 errors like:
|
Taking a set of unrelated changes we can bring to main. This will make the diff in #1118 easier to review.
After analysis of log submitted
with generated MCW code:
Following class was suspicious:
But it is generated in both cases (net8.0/net8.0 and net8.0+net10.0/net10.0)
|
…rator-workarounds Conflicts: .gitignore build/scripts/provision-android/provision-android.csproj
After reviewing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On further review, we think apicompat
is all good:
Replacement PR for
#1058
for automatic builds (no need for manual
/azp run
comments).Related:
issue
How to support .NET MAUI on .NET 10? #1084
PR (closed)
Build with
TargetFramework=net10.0
#1079MAUI PR using nugets from this build
[DO NOT MERGE][net10.0] 20250414 net10.0 ecosytem updates maui#28997
To build this migration PR use following command:
or even better:
git clean -xdf ; dotnet cake -t=build-android-libraries-net10-net8
And standard build is still according to documentation: